Empresas
Empleos
  • Sobre nosotros
  • Soluciones
    • Publicación de vacantes
      Publica tu vacante y recibe candidatos calificados en 48h.
    • Evaluación de candidatos
      500+ pruebas técnicas y psicológicas, más anti-fraude.
    • Headhunting
      Búsqueda ejecutiva a la medida de principio a fin.
    • Nómina + EOR
      Dispersión de nómina y EOR en más de 15 países de LATAM.
  • Precios
  • Empleos

0

136
Vistas
React menu hamburger causes layout children to rerender

I am using React and Material UI v5. I have a menu component inside my layout that has children. When clicking on the menu it causes the children to refresh. I have tried solving it by wrapping the children components in React.memo(child) but the result is still the same. What am I doing wrong?

menu component

const MyMenu = ({ menuAnchorEl, setMenuAnchorEl }) => {
    const menuOpen = Boolean(menuAnchorEl);

    const handleMenuClose = () => {
        setMenuAnchorEl(null);
    };

    const menuOptions = [
        {
            link: '/overview',
            Icon: Dashboard,
            label: 'Overview',
        },
    ];

    const MenuOption = ({
        link,
        Icon,
        label,
    }: {
        link: string;
        Icon: OverridableComponent<SvgIconTypeMap<unknown, 'svg'>> & {
            muiName: string;
        };
        label: string;
    }) => {
        return (
            <NavLink href={link}>
                <MenuItem>
                    <ListItemIcon>
                        <Icon color="secondary" fontSize="small" />
                    </ListItemIcon>
                    <ListItemText sx={{ color: 'text.primary' }}>
                        {label}
                    </ListItemText>
                    <Typography variant="body2"></Typography>
                </MenuItem>
            </NavLink>
        );
    };

    return (
        <Menu
            anchorEl={menuAnchorEl}
            open={menuOpen}
            onClose={handleMenuClose}
            variant="selectedMenu"
        >
            <MenuList>
                {menuOptions.map((n) => (
                    <MenuOption key={n.link} {...n} />
                ))}
            </MenuList>
        </Menu>
    );
};

layout component

const MyLayout = observer(({ children }: IProps) => {
    const classes = useStyles();
    const [menuAnchorEl, setMenuAnchorEl] = React.useState<null | HTMLElement>(
        null,
    );

    return (
        <>
            <Hidden mdDown implementation="css">
                <InstallerMenu
                    menuAnchorEl={menuAnchorEl}
                    setMenuAnchorEl={setMenuAnchorEl}
                />
                <div className={classes.appFrame}>
                    <div className={classes.container}>{children}</div>
                </div>
            </Hidden>
        </>
    );
});
about 4 years ago · Juan Pablo Isaza
1 Respuestas
Responde la pregunta

0

You have the MenuOption Component inside MyMenu and each time react re-render the main component MyMenu the MenuOption get re defined and cause all the children's to re-render again, in order to fix the issue you must take the MenuOption outside the main components and pass the required props to it, your code will look like this

alos read this article to know more why component inside component is bad

const MyMenu = ({ menuAnchorEl, setMenuAnchorEl }) => {
    const menuOpen = Boolean(menuAnchorEl);

    const handleMenuClose = () => {
        setMenuAnchorEl(null);
    };

    const menuOptions = [
        {
            link: '/overview',
            Icon: Dashboard,
            label: 'Overview',
        },
    ];

    return (
        <Menu
            anchorEl={menuAnchorEl}
            open={menuOpen}
            onClose={handleMenuClose}
            variant="selectedMenu"
        >
            <MenuList>
                {menuOptions.map((n) => (
                    <MenuOption key={n.link} {...n} />
                ))}
            </MenuList>
        </Menu>
    );
};


function MenuOption({requiredProps}){
return (
    <NavLink href={link}>
        <MenuItem>
            <ListItemIcon>
                <Icon color="secondary" fontSize="small" />
            </ListItemIcon>
            <ListItemText sx={{ color: 'text.primary' }}>
                {label}
            </ListItemText>
            <Typography variant="body2"></Typography>
        </MenuItem>
    </NavLink>
);
 };
about 4 years ago · Juan Pablo Isaza Denunciar
Responde la pregunta
Encuentra empleos remotos

¡Descubre la nueva forma de encontrar empleo!

Top de empleos
Top categorías de empleo
Empresas
Publicar vacante Precios Comercial
Legal
Términos y condiciones Política de privacidad
© 2026 PeakU Inc. All Rights Reserved.
Andres GPT
Recomiéndame algunas ofertas
Necesito ayuda