Logré escribir un código que hace lo que necesito, pero quiero limpiarlo y eliminar la mutación de realtiveGroups.push() pero no sé cómo lograrlo. ¿Cómo eliminar la mutación de este código?
export interface OfferCategory { id: string; name: string; } export interface OfferGroup { groupId: string; dependsOn: OfferCategory; name: string; rule: Rule; products: PosProducts[]; } function relativesFromSubscription(groups: OfferGroup[], dependingGroups: OfferGroup[]): OfferGroup[] { const relativeGroups: OfferGroup[] = []; groups.forEach(group => { if (dependingGroups.some(dependingGroup => group?.dependsOn?.id === dependingGroup.groupId)) { relativeGroups.push(group); } if (relativeGroups.some(relativeGroup => group?.dependsOn?.id === relativeGroup.groupId)) { relativeGroups.push(group); } }); return relativeGroups; }En lugar de hacer todo en un ciclo, intente dividirlo en unos pocos:
function relativesFromSubscription(groups: OfferGroup[], dependingGroups: OfferGroup[]): OfferGroup[] { const groups1 = groups.filter(group => dependingGroups.some(dependingGroup => group?.dependsOn?.id === dependingGroup.groupId)); const groups2 = groups.filter(group => groups1.some(relGroup=> group?.dependsOn?.id === relGroup.groupId)); return [...groups1, ...groups2]; }Usando su código y Array.filter
const relativeGroups: OfferGroup[] = groups.filter(group => { return dependingGroups.some(dependingGroup => group?.dependsOn?.id === dependingGroup.groupId) || relativeGroups.some(relativeGroup => group?.dependsOn?.id === relativeGroup.groupId) });O si desea que el código sea más legible, puede agregar variables descriptivas:
const relativeGroups: OfferGroup[] = groups.filter(group => { const hasDependingGroups = dependingGroups.some(dependingGroup => group?.dependsOn?.id === dependingGroup.groupId); const hasRelativeGroups = relativeGroups.some(relativeGroup => group?.dependsOn?.id === relativeGroup.groupId) return hasDependingGroups || hasRelativeGroups });