Im working on a AlgoExpert challenge, I already dedicated time to solving it on my own, watched the video lecture on it and I feel like I have a good understanding, but my skills with recursion and Tree traversal are pretty low right now (that's why I'm working on it).
This is the prompt
Write a function that takes in a Binary Search Tree (BST) and a target integer value and returns the closest value to that target value contained in the BST. Each BST node has an integer value, a left child node, and a right child node. Its children's are valid BST nodes themselves or None / Null
TARGET: 12
This is my solution so far:
function findClosestValueInBst(tree, target) {
let closest = tree.value;
const traverse = (inputTree) => {
if (inputTree === null) return;
if (Math.abs(target - closest) > Math.abs(target - inputTree.value)) {
closest = inputTree.value;
}
if (target < tree.value) {
console.log('left')
traverse(inputTree.left)
} else {
console.log('right')
traverse(inputTree.right)
}
}
traverse(tree)
return closest;
}
// This is the class of the input tree. Do not edit.
class BST {
constructor(value) {
this.value = value;
this.left = null;
this.right = null;
}
}
The behavior so far is, traverse to Node 15, but then, instead of going to 13, it goes to 22 so it returns 10 as the closes possible value instead of 13 which has an absolute value closer to 12 than 10.
function findClosestValueInBst(tree, target) {
let closest = tree.value;
const traverse = (inputTree) => {
if (inputTree === null) return;
if (Math.abs(target - closest) > Math.abs(target - inputTree.value)) {
closest = inputTree.value;
}
// As you can see below this line you are checking target < tree.value
// problem is that tree is the root that your surrounding function gets
// not the argument that your recursive function gets.
// both your condition and your parameter to traverse
// need to be inputTree, not tree
if (target < tree.value) {
console.log('left')
traverse(inputTree.left)
} else {
console.log('right')
traverse(inputTree.right)
}
}
traverse(tree)
return closest;
}
Now look at the code below:
function findClosestValueInBst(root, target) {
let closest = root.value;
const traverse = (node) => {
if (node === null) return;
if (Math.abs(target - closest) > Math.abs(target - node.value)) {
closest = node.value;
}
if (target < node.value) {
console.log('left')
traverse(node.left)
} else {
console.log('right')
traverse(node.right)
}
}
traverse(root)
return closest;
}
In such cases it is helpful to name the parameters more distinct so that no confusion arises.
Using Nina Scholz's test cases, but what I see as a simpler recursion, we can do this:
const closer = (v) => (x, y) =>
Math.abs (x - v) < Math .abs (y - v) ? x : y
const findClosestValueInBst = (node, target) =>
node == null
? Infinity
: target == node .value
? node .value
: target < node .value
? closer (target) (findClosestValueInBst (node .left, target), node .value)
: closer (target) (findClosestValueInBst (node .right, target), node .value)
const tree = { value: 10, left: { value: 7, left: { value: 5, left: null, right: null }, right: { value: 8, left: null, right: null } }, right: { value: 13, left: { value: 11, left: null, right: null }, right: { value: 15, left: null, right: null } } };
console .log (findClosestValueInBst (tree, 11))
console .log (findClosestValueInBst (tree, 12))
console .log (findClosestValueInBst (tree, 13))
console .log (findClosestValueInBst (tree, 14))
console .log (findClosestValueInBst (tree, 15))
console .log (findClosestValueInBst (tree, 16))
console .log (tree).as-console-wrapper {max-height: 100% !important; top: 0}The closer helper simply chooses which of two numbers is closer to a target, arbitrarily choosing the second one if they are equally close.
The main function simply escapes with an infinite value if the tree supplied is null, and then branches on whether our target is equal to, less than, or greater than the current node's value. If equal, we're done and return the node's value. If less than, we recur on the left branch and then choose the closer of that result and the node value, and similarly, if greater than, we do the same thing with the right branch.
Note that my answers can be different from Nina's because we make different arbitrary choices about whether, say, 11 or 13 is closer to 12.
Maybe this works.
It checks the node in a single function and uses the last value with an initial value of a large value.
Then it finds if the target is found and returns the target.
Otherwise check if the target is inside
function findClosestValue(tree, target, last = tree.value) {
if (tree === null) return last;
if (tree.value === target) return target;
if (
last < target && target < tree.value ||
tree.value < target && target < last
) return Math.abs(target - this.value) < Math.abs(target - last)
? this.value
: last;
return target < tree.value
? findClosestValue(tree.left, target, tree.value)
: findClosestValue(tree.right, target, tree.value);
}
const
tree = { value: 10, left: { value: 7, left: { value: 5, left: null, right: null }, right: { value: 8, left: null, right: null } }, right: { value: 13, left: { value: 11, left: null, right: null }, right: { value: 15, left: null, right: null } } };
console.log(findClosestValue(tree, 11));
console.log(findClosestValue(tree, 12));
console.log(findClosestValue(tree, 13));
console.log(findClosestValue(tree, 14));
console.log(findClosestValue(tree, 15));
console.log(findClosestValue(tree, 16));
console.log(tree);.as-console-wrapper { max-height: 100% !important; top: 0; }