Business
Jobs
  • About Us
  • Solutions
    • Job Postings
      Post your job and receive qualified candidates in 48h.
    • Candidate Assessments
      500+ technical and psychological tests, plus anti-fraud.
    • Headhunting
      Tailor-made executive search from start to finish.
    • Payroll + EOR
      Payroll dispersal and EOR across 15+ LATAM countries.
  • Pricing
  • Jobs

0

158
Views
Is possible to make function from code and make it shorter?

I have this lines of code

let value = productDetails.recentPurchaseDate;
if (!productDetails.salesPrice && !productDetails.recentPurchaseDate) {
  value = false;
}
if (!productDetails.presentEstimatedValue) {
  value = true;
}

Is it possible to refactor, I need to make it function and this two IF? Thanks in advance

about 4 years ago · Juan Pablo Isaza
3 answers
Answer question

0

Generally I don't think it is well designed if-conditions, but I don't know your business requirements. Let's try with something like this

let value = productHasRecentPurchaseDate(productDetails); //name should math your business goal

function productHasRecentPurchaseDate(productDetails) {
    if (!productDetails.salesPrice && !productDetails.recentPurchaseDate) {
       return false;
    }
    else if (!productDetails.presentEstimatedValue) {
       return true;
    }
    else {
        return /*you need all if statement path to return some value, this is last one, please provide what those statements should return if both previous conditions fail*/;
    }
}
about 4 years ago · Juan Pablo Isaza Report

0

You can do it like this

function getValue({
    salesPrice,
    recentPurchaseDate,
    presentEstimatedValue
}) {
    if (!salesPrice && !recentPurchaseDate) return false;
    if (!presentEstimatedValue) return true
    return recentPurchaseDate
}

and then

let value = getValue(productDetails);
about 4 years ago · Juan Pablo Isaza Report

0

Something like that?

const value = yourNewFn();
function yourNewFn() {
    if (!productDetails.salesPrice && !productDetails.recentPurchaseDate) {
    value = false;
  }
  if (!productDetails.presentEstimatedValue) {
    value = true;
  }
  return value;
}

about 4 years ago · Juan Pablo Isaza Report
Answer question
Find remote jobs

Discover the new way to find a job!

Top jobs
Top job categories
Business
Post vacancy Pricing Sales
Legal
Terms and conditions Privacy policy
© 2026 PeakU Inc. All Rights Reserved.
Andres GPT
Show me some job opportunities
There's an error!