Question

Views

I know there is a way for writing a Java if statement in short form.

if (city.getName() != null) {
    name = city.getName();
} else {
    name="N/A";
}

Does anyone know how to write the short form for the above 5 lines into one line?

over 4 years ago · Santiago Trujillo

To avoid calling .getName() twice I would use

name = city.getName();
if (name == null) name = "N/A";

over 4 years ago · Santiago Trujillo Report

The way to do it is with ternary operator:

name = city.getName() == null ? city.getName() : "N/A"

However, I believe you have a typo in your code above, and you mean to say:

if (city.getName() != null) ...

over 4 years ago · Santiago Trujillo Report

Answer question

Accepted Answer · 2022-04-28T21:29:18.878Z

Use the ternary operator:

name = ((city.getName() == null) ? "N/A" : city.getName());

I think you have the conditions backwards - if it's null, you want the value to be "N/A".

What if city is null? Your code *hits the bed in that case. I'd add another check:

name = ((city == null) || (city.getName() == null) ? "N/A" : city.getName());