I'm given a promise and am returning it at the end of my function for other code to do more actions after me. A kind of middleware, if you will.

return apiCallPromise;

Lets say for some reason I wish to stop those actions from happening and "swallow" a particular promise. For example by doing the following:

if (promiseShouldBeStopped) return new Promise((resolve) => {})
return apiCallPromise;

This correctly returns a promise, however it never resolves. And so the 'promise chain' has been stopped dead in its tracks.

This seems like an anti-pattern to me as it the promise is left pending forever. Are there any bad effects of this that I should be aware of, or is this a fine technique for "filtering" promises?

Attempt to answer my own question

Does this cause memory issues?

Future code doesn't know that this promise has been filtered out, and so fails to do any "catch" or "finally" cleanup code.

• In my case this is not relevant, and I want this code to take care of those errors so that the future code doesn't have to deal with them. (this means I can guarantee that onFulfilled gives the api response, and onRejected only gives an error that is actually unexpected)